-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create a single queue for the controller to use #140
Open
shreddedbacon
wants to merge
18
commits into
main
Choose a base branch
from
queue-reduction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…controller into queue-reduction
shreddedbacon
force-pushed
the
queue-reduction
branch
from
November 2, 2022 06:22
770aac5
to
7f88c45
Compare
3 tasks
shreddedbacon
force-pushed
the
queue-reduction
branch
from
November 2, 2022 08:11
952ca13
to
4ef498b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
To try and standardise the messaging to the controller, implement 1 single queue that uses a new type
LagoonEvent
that haslagoon:build
lagoon:task
lagoon:removal
lagoon:misc
The single queue is enabled by default, and will still start the existing 4 queues for the time being. This allows the controller to be rolled out over time supporting the new single queue option, and then a Lagoon-core update will be released that changes to the single queue option by default.
A clean up script to remove the old queues will be provided with the lagoon-core release when it happens.
Closing issues
closes #138